Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable H2 shutdown hook #4106

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Aug 31, 2024

Description

Disables H2 shutdown hook.

H2 registers a JVM shutdown hook to close the database upon reception of SIGTERM. However, the hook executes before the servlet context has shut down, so event processing can still be going on at that time, causing a flood of "database already closed" exceptions.

The H2 database is already closed as part of Alpine's PersistenceManagerFactory#contextDestroyed method, thus making the additional shutdown hook of H2 redundant anyway.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

H2 registers a JVM shutdown hook to close the database upon reception of `SIGTERM`. However, the hook executes before the servlet context has shut down, so event processing can still be going on at that time, causing a flood of "database already closed" exceptions.

The H2 database is already closed as part of Alpine's `PersistenceManagerFactory#contextDestroyed` method, thus making the additional shutdown hook of H2 redundant anyway.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the enhancement New feature or request label Aug 31, 2024
@nscuro nscuro added this to the 4.12 milestone Aug 31, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fcbc723) 22251 17080 76.76%
Head commit (da631dd) 22251 (+0) 17080 (+0) 76.76% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4106) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit caaeb53 into DependencyTrack:master Aug 31, 2024
11 checks passed
@nscuro nscuro deleted the disable-h2-shutdown-hook branch August 31, 2024 21:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant