Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deploying Docker guide to Compose v2 #4276

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

danihengeveld
Copy link
Contributor

Description

  • Updated the Deploying Docker Container guide to use Compose v2, so docker compose instead of docker-compose. Also added guidance for installing compose.
  • Added the ALPINE_OIDC_CLIENT_ID environment variable to the Docker Compose example.
  • Removed the top-level version element from the example and the docker-compose.yml file because it is obsolete.

Addressed Issue

Closes #3939.

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@danihengeveld danihengeveld force-pushed the issue-3939 branch 2 times, most recently from 5e88440 to f370e5a Compare October 18, 2024 09:52
- Added `ALPINE_OIDC_CLIENT_ID` environment variable to example.
- Removed `docker-compose.yml` version top-level element (obsolote).

Signed-off-by: Dani Hengeveld <dani10hengeveld@gmail.com>
@nscuro nscuro added this to the 4.13 milestone Oct 18, 2024
@nscuro nscuro added the documentation Improvements or additions to documentation label Oct 18, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1df119e) 22549 17853 79.17%
Head commit (2fe1401) 22549 (+0) 17853 (+0) 79.17% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4276) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 7bba6c2 into DependencyTrack:master Oct 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the documentation around Docker Compose
2 participants