Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi line annotations at services #57

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix multi line annotations at services #57

merged 1 commit into from
May 21, 2024

Conversation

tvannahl
Copy link
Contributor

Fix #56 for service annotations across multiple lines.

nscuro
nscuro requested changes May 19, 2024
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvannahl!

Please sign-off your commits so the DCO check passes. You can find instructions by clicking on the Details link next to the failing DCO check.

Also, please bump the chart version to 0.6.1.

@nscuro nscuro added the defect Something isn't working label May 19, 2024
@tvannahl tvannahl force-pushed the fix-multiline-annotations branch 2 times, most recently from e3da005 to 79b2962 Compare May 21, 2024 08:47
@tvannahl
Fix multi line annotations at services
92241ae 
Fix DependencyTrack#56 for service annotations across multiple lines.

Signed-off-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
@tvannahl tvannahl force-pushed the fix-multiline-annotations branch from 79b2962 to 92241ae Compare May 21, 2024 08:50
@tvannahl
Copy link
Contributor Author

@nscuro Thank you, I've rebased and signed off.

Let me know if there is something missing.

@nscuro nscuro merged commit f20c141 into DependencyTrack:main May 21, 2024
4 checks passed
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@NissesSenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades
6cad4c1 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro mentioned this pull request Jun 12, 2024
Merged
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@NissesSenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades
81e3fc5 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@NissesSenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades
29d3478 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@NissesSenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades (#91)
f9336b6 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Signed-off-by: nscuro <nscuro@protonmail.com>
Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
defect Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML parse error when defining multi line annotations
2 participants
@tvannahl @nscuro