Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload policy evaluation to internal task queue #160

Merged
merged 1 commit into from
May 11, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 10, 2023

Description

Execute policy evaluations in DT's internal task queue instead of in a Kafka consumer thread.

This is a temporary solution until we have policy evaluation in a state where it cannot block the Kafka consumer thread for too long anymore.

Addressed Issue

Relates to DependencyTrack/hyades#529

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label May 10, 2023
Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

This is a temporary solution until we have policy evaluation in a state where it cannot block the Kafka consumer thread for too long anymore.

Relates to DependencyTrack/hyades#529

Signed-off-by: nscuro <nscuro@protonmail.com>
@sahibamittal sahibamittal merged commit 323c36a into main May 11, 2023
@sahibamittal sahibamittal deleted the hyades-issue-529 branch May 11, 2023 10:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants