Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY title & content #493

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Dec 18, 2023

Description

Fixes a regression introduced in #488, causing the title, content, and affectedProjectsReference fields to not be populated for NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notifications.

Addressed Issue

This was catched by our e2e test suite: https://github.com/DependencyTrack/hyades/actions/runs/7246855565/job/19739750955

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the defect Something isn't working label Dec 18, 2023
… title & content

Signed-off-by: nscuro <nscuro@protonmail.com>
Copy link
Collaborator

@mehab mehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nscuro nscuro merged commit ca08224 into main Dec 18, 2023
6 checks passed
@nscuro nscuro deleted the notification-regression branch December 18, 2023 16:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
@nscuro nscuro added this to the 5.3.0 milestone Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants