Fix inconsistent AnalysisComment ordering in case of equal timestamp values
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp` values As of recently, multiple `AnalysisComments` are created with the same `timestamp` (due to the creation happening in a single transaction). This messes with the default ordering of comments. In addition to `timestamp`, also sort by `id` to retain the intended ordering. Signed-off-by: nscuro <nscuro@protonmail.com>
sahibamittal
approved these changes
Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes inconsistent
AnalysisCommentordering in case of equaltimestampvaluesAs of recently, multiple
AnalysisCommentsare created with the sametimestamp(due to the creation happening in a single transaction). This messes with the default ordering of comments.In addition to
timestamp, also sort byidto retain the intended ordering.Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly