Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Validate uploaded BOMs against CycloneDX schema #715

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jun 11, 2024

Description

Ports the following PRs from Dependency-Track v4.11.x:

The following parts were not ported:

  • ConfigKey.BOM_PROCESSING_TASK_V2_ENABLED / ConfigPropertyConstants.BOM_PROCESSING_TASK_V2_ENABLED: Hyades does not have two separate versions of the task, it's already on V2 exclusively.

Addressed Issue

Relates to DependencyTrack/hyades#1190

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jun 11, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 11, 2024
Copy link

codacy-production bot commented Jun 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.14% (target: -1.00%) 86.11% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (df57c53) 19893 16217 81.52%
Head commit (f6ee463) 20013 (+120) 16343 (+126) 81.66% (+0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#715) 144 124 86.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Ports the following PRs from Dependency-Track v4.11.x:

* DependencyTrack/dependency-track#3522
* DependencyTrack/dependency-track#3621
* DependencyTrack/dependency-track#3698

The following parts were **not** ported:

* `ConfigKey.BOM_PROCESSING_TASK_V2_ENABLED` / `ConfigPropertyConstants.BOM_PROCESSING_TASK_V2_ENABLED`: Hyades does not have two separate versions of the task, it's already on V2 exclusively.

Co-authored-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahibamittal sahibamittal merged commit 3f4ad8c into main Jun 18, 2024
9 checks passed
@sahibamittal sahibamittal deleted the port-pr-3522 branch June 18, 2024 09:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants