Port: Perform License Resolution On Name Field During SBOM Import #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports DependencyTrack/dependency-track#3555 from Dependency-Track v4.11.0. The main logic was already ported via #705. This PR contains the missing test case. Co-authored-by: Aravind Parappil <aravindparappil@gmail.com> Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
added
defect
2 tasks
Ports tests from DependencyTrack/dependency-track#3556 of Dependency-Track v4.11.0. The logic change in that PR was only necessary for the legacy `BomUploadProcessingTask`, which does not exist in Hyades anymore. Co-authored-by: Aravind Parappil <aravindparappil@gmail.com> Signed-off-by: nscuro <nscuro@protonmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
sahibamittal
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports the following PRs from Dependency-Track v4.11.0:
The main logic was already ported via #705. This PR contains the missing test cases.
Addressed Issue
Relates to DependencyTrack/hyades#1190
Additional Details
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly