Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Fix JDOFatalUserException for long reference URLs from OSS Index #747

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 18, 2024

Description

Fixes JDOFatalUserException for long reference URLs from OSS Index.

When a reference URL won't fit in the respective database column, try to drop its query parameters first, and if that doesn't help (unlikely), make a hard cut at 255 characters.

Addressed Issue

Backport change DependencyTrack/hyades#1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-Authored-By: Niklas <nscuro@protonmail.com>
@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base defect Something isn't working labels Jun 18, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 18, 2024
@sahibamittal sahibamittal merged commit 37c8934 into main Jun 18, 2024
7 checks passed
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 87.50% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b6d66ea) 20381 16633 81.61%
Head commit (612c0f4) 20387 (+6) 16643 (+10) 81.64% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#747) 8 7 87.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal deleted the port-fix-JDOFatalUserException-oss-index branch June 18, 2024 13:43
@nscuro nscuro changed the title Port : Fix JDOFatalUserException for long reference URLs from OSS Index Port: Fix JDOFatalUserException for long reference URLs from OSS Index Jun 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants