Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Fix CPE matching for NVD mirroring via REST API #1631

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jan 22, 2025

Description

Fixes CPE matching for NVD mirroring.

Addressed Issue

Port change #1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-Authored-By: Niklas <nscuro@protonmail.com>
Co-Authored-By: Thomas Calderon <766422+calderonth@users.noreply.github.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+18.27% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (09c253b) 201 132 65.67%
Head commit (39a2c4b) 6899 (+6698) 5791 (+5659) 83.94% (+18.27%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1631) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base defect Something isn't working domain/vuln-mirroring labels Jan 22, 2025
@nscuro nscuro merged commit d0465aa into main Jan 22, 2025
12 checks passed
@nscuro nscuro deleted the port-Fix-CPE-matching-for-NVD branch January 22, 2025 19:08
@nscuro nscuro added this to the 0.6.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working domain/vuln-mirroring v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants