options

DerThorsten · Nov 16, 2024 · f87db33 · f87db33
1 parent c9e1aed
commit f87db33
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/include/sparrow/builder/builder.hpp b/include/sparrow/builder/builder.hpp
@@ -57,7 +57,7 @@ inline constexpr large_binary_flag_t large_binary_flag;
 template<class T, class ... OPTION_FLAGS>
 auto build(T&& t, OPTION_FLAGS&& ... )
 {
-    using option_flags_type = sparrow::mpl::typelist<OPTION_FLAGS...>;
+    using option_flags_type = sparrow::mpl::typelist<std::decay_t<OPTION_FLAGS>...>;
     return detail::builder<T, option_flags_type>::create(std::forward<T>(t));
 }
 

diff --git a/include/sparrow/utils/mp_utils.hpp b/include/sparrow/utils/mp_utils.hpp
@@ -238,7 +238,7 @@ namespace sparrow::mpl
     ///          `false` otherwise or if the list is empty.
     template <class Predicate, template <class...> class L, class... T>
         requires any_typelist<L<T...>> and (callable_type_predicate<Predicate, T> && ...)
-    consteval bool any_of(L<T...>, Predicate predicate = {})
+    consteval bool any_of(L<T...>, [[maybe_unused]] Predicate predicate = {})
     {
         return (evaluate<T>(predicate) || ... || false);
     }

diff --git a/src/array_factory.cpp b/src/array_factory.cpp
@@ -13,7 +13,6 @@
 // limitations under the License.
 
 #include <memory>
-
 #include "sparrow/array_factory.hpp"
 #include "sparrow/layout/list_layout/list_array.hpp"
 #include "sparrow/layout/struct_layout/struct_array.hpp"

diff --git a/test/test_builder.cpp b/test/test_builder.cpp
@@ -89,10 +89,23 @@ namespace sparrow
                 };
                 sanity_check(sparrow::build(v));
             }
-            SUBCASE("large-list")
+            SUBCASE("options")
             {   
-                std::vector<std::vector<float>> v{{1.0f, 2.0f, 3.0f}, {4.0f, 5.0f}};
-                auto arr = sparrow::build(v, sparrow::large_list_flag);
+                SUBCASE("with_large_list_flag")
+                {
+                    std::vector<std::vector<float>> v{{1.0f, 2.0f, 3.0f}, {4.0f, 5.0f}};
+                    auto arr = sparrow::build(v, sparrow::large_list_flag);
+                    using array_type = std::decay_t<decltype(arr)>;
+                    static_assert(std::is_same_v<array_type, sparrow::big_list_array>);
+                }
+                SUBCASE("without_large_list_flag")
+                {
+                    std::vector<std::vector<float>> v{{1.0f, 2.0f, 3.0f}, {4.0f, 5.0f}};
+                    auto arr = sparrow::build(v);
+                    using array_type = std::decay_t<decltype(arr)>;
+                    static_assert(std::is_same_v<array_type, sparrow::list_array>);
+                }
+
             }
         }
         TEST_CASE("struct-layout")