Various improvements: aggregate functions, insert set syntax, & update join syntax #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekStride
changed the title
DerekStride
force-pushed
the
ds/various-improvements
branch
from
77e901a to
0efb1c0
Compare
|
Wow @DerekStride, kudos to you! This quick and comprehensive response by far exceeds all my expectations! I will test your branch as well, to confirm the fixes. |
dmfay
approved these changes
Jan 21, 2023
| @@ -1000,6 +990,11 @@ module.exports = grammar({ | |||
| ')', | |||
| ), | |||
|
|
|||
| _aggregate_function: $ => choice( | |||
* Also updates the values branch of the grammar to allow for specifying multiple lists of items.
Previous to this commit `count` was a special case node. It worked a lot like the `invocation` node but had some custom grammar rules. This commit introduced another special case node, group_concat. According to the MySQL reference there might not be many more like this but to provide a pattern for the future I moved both count & group_concat into a special anonymous node called `_aggregate_functions`. https://dev.mysql.com/doc/refman/8.0/en/aggregate-functions.html
Previously there was separate anonymous nodes for single table & multi table update statements. This commit merges them into a single node and reworks them to support the JOIN syntax.
* Postgres supports a from-clause after the assignment list in the `set` clause.
DerekStride
force-pushed
the
ds/various-improvements
branch
from
0efb1c0 to
61c6e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There are 3 updates that fix the issues described in #67.
cc// @LeoniePhiline
Update insert to support SET syntax
3f08080
2fdc428
Also updates the values branch of the grammar to allow for specifying multiple lists of items. The other commit includes support for the postgres style update statement.
Rework special cases for aggregate functions
8c0ca86
61c6e23
Previous to this commit
countwas a special case node. It worked a lot like theinvocationnode but had some custom grammar rules.This commit introduced another special case node, group_concat. According to the MySQL reference there might not be many more like this but to provide a pattern for the future I moved both count & group_concat into a special anonymous node called
_aggregate_functions.The other commit adds the
_aggregate_expressionnode from the suggestions.Consolidate UPDATE rules into 1 node
3b82416
Previously there was separate anonymous nodes for single table & multi table update statements. This commit merges them into a single node and reworks them to support the JOIN syntax.