Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for nested joins #75

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Allow for nested joins #75

merged 2 commits into from
Jan 31, 2023

Conversation

wishdev
Copy link
Contributor

@wishdev wishdev commented Jan 30, 2023

This simply adds the ability to nest joins.

dmfay
dmfay approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@dmfay dmfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow I had no idea this was possible but sure enough it is. Looks good to me, if you could merge or rebase on main and resolve the conflicts with the generated files 👍

@wishdev wishdev mentioned this pull request Jan 31, 2023
Merged
@wishdev
Copy link
Contributor Author

wishdev commented Jan 31, 2023

This has been rebased

@dmfay dmfay merged commit bb58ae1 into DerekStride:main Jan 31, 2023
@wishdev wishdev deleted the nested_join branch March 2, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfay dmfay dmfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wishdev @dmfay