Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

懒加载和多切面增强 #40

Merged
merged 2 commits into from
Dec 23, 2022
Merged

懒加载和多切面增强 #40

merged 2 commits into from
Dec 23, 2022

Conversation

zqczgl
Copy link
Contributor

@zqczgl zqczgl commented Dec 22, 2022

No description provided.

@DerekYRC DerekYRC merged commit f1cf4fb into DerekYRC:lazy-init-and-multi-advice Dec 23, 2022
@DerekYRC
Copy link
Owner

@zqczgl 有单测未通过，麻烦看看
image

@zqczgl
Copy link
Contributor Author

zqczgl commented Dec 23, 2022

@zqczgl 有单测未通过，麻烦看看 image

@DerekYRC 这里出错是因为我更改了ProxyFactory的结构，之前的代码是将AdvisedSupport作为ProxyFactory的内部属性。但springAOP真正做的是让ProxyFactory继承AdvisedSupport。我选择了和spring保持一致，这里的测试类我没有重写所以导致了错误，可以简单的将这个测试类删除因为我已经在ProxyFactoryTest中做了同样的测试，或者我也可以将这个测试类重写一下。

@DerekYRC
Copy link
Owner

@zqczgl 有单测未通过，麻烦看看 image

@DerekYRC 这里出错是因为我更改了ProxyFactory的结构，之前的代码是将AdvisedSupport作为ProxyFactory的内部属性。但springAOP真正做的是让ProxyFactory继承AdvisedSupport。我选择了和spring保持一致，这里的测试类我没有重写所以导致了错误，可以简单的将这个测试类删除因为我已经在ProxyFactoryTest中做了同样的测试，或者我也可以将这个测试类重写一下。

辛苦重写一下吧，一般不要删除单元测试

@zqczgl
Copy link
Contributor Author

zqczgl commented Dec 23, 2022

@zqczgl 有单测未通过，麻烦看看 image

@DerekYRC 这里出错是因为我更改了ProxyFactory的结构，之前的代码是将AdvisedSupport作为ProxyFactory的内部属性。但springAOP真正做的是让ProxyFactory继承AdvisedSupport。我选择了和spring保持一致，这里的测试类我没有重写所以导致了错误，可以简单的将这个测试类删除因为我已经在ProxyFactoryTest中做了同样的测试，或者我也可以将这个测试类重写一下。

辛苦重写一下吧，一般不要删除单元测试

@DerekYRC 更改完毕

@DerekYRC
Copy link
Owner

@zqczgl 辛苦了，周末我再合并到main分支

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zqczgl @DerekYRC