Skip to content

Bug/WC-33: Fix NEES DOI links by appending project root to paths #2789

Bug/WC-33: Fix NEES DOI links by appending project root to paths

Bug/WC-33: Fix NEES DOI links by appending project root to paths #2789

Triggered via pull request September 18, 2024 17:04
Status Success
Total duration 1m 23s
Artifacts

main.yml

on: pull_request
Server_Side_Unit_Tests
1m 1s
Server_Side_Unit_Tests
Server_Side_Linting
23s
Server_Side_Linting
Client_Side_Unit_Tests
52s
Client_Side_Unit_Tests
React_NX_unit_tests
1m 10s
React_NX_unit_tests
React_NX_linting
32s
React_NX_linting
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
Server_Side_Linting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
React_NX_linting: client/src/workspace/layouts/AppsViewLayout.tsx#L51
Using target="_blank" without rel="noreferrer" (which implies rel="noopener") is a security risk in older browsers: see https://mathiasbynens.github.io/rel-noopener/#recommendations
React_NX_linting: client/modules/datafiles/src/projects/modals/ChangeProjectTypeModal.tsx#L133
React Hook useMemo has a missing dependency: 'showProtectedDataOptions'. Either include it or remove the dependency array
React_NX_linting: client/modules/datafiles/src/projects/modals/ProjectInfoStepper/ExperimentalSteps.tsx#L168
The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md
React_NX_linting: client/modules/datafiles/src/projects/modals/ProjectInfoStepper/SimulationSteps.tsx#L167
The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md
Server_Side_Unit_Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/