Task/DES-3065: Use cloud.data system for HPC work directories #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstijerina
reviewed
Aug 30, 2024
rstijerina
reviewed
Aug 30, 2024
rstijerina
reviewed
Aug 30, 2024
rstijerina
reviewed
Aug 30, 2024
| @@ -103,7 +104,7 @@ export const DatafilesToolbar: React.FC<{ searchInput?: React.ReactNode }> = ({ | |||
| // Disable downloads from frontera.work until we have a non-flaky mount on ds-download. | |||
| canDownload: | |||
| selectedFiles.length >= 1 && | |||
| system !== 'designsafe.storage.frontera.work' && | |||
| system !== USER_WORK_SYSTEM && | |||
There was a problem hiding this comment.
I didn't realize this was set - great, so user the Work tapis download feature can be done later and no current functionality is lost 👍
rstijerina
reviewed
Sep 3, 2024
client/modules/datafiles/src/DatafilesModal/CopyModal/CopyModal.tsx
Outdated
Show resolved
Hide resolved
rstijerina
reviewed
Sep 3, 2024
| const systemRoot = isUserHomeSystem(system) ? '/' + user?.username : ''; | ||
| let systemRoot = ''; | ||
| if (system === USER_MYDATA_SYSTEM) systemRoot = '/' + user?.username; | ||
| if (system === USER_WORK_SYSTEM) systemRoot = '/work/' + user?.homedir; |
There was a problem hiding this comment.
This might need to specify that the existing path starts with /work as well, otherwise we get this:
1 task
* commit to main * prevent blank or null values from causing metrics page to crash * remove those type coercions and fix the type errors * Refactor MetricsModalBody component to improve readability and maintainability * remove docker compose changes --------- Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
…1432) * Log DOIs for each file when multiple are selected, even if there are duplicates * Unset file selections when changing the selected publication version
…ation listing (#1425) * Directories in Publication Preview open in the Curation listing * fix links inside the publication pipeline * revert link _target change
…he root dir (#1433) * log views of non-Other type projects as listings on the root dir * fix hook dependencies
* handle error in revoke method * handle cloud.data work system in workspace select modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Replace the tg-owned HPC works system with cloud.data and users' personal home directories
PR Status:
Related Jira tickets:
Summary of Changes:
designsafe.storage.frontera.workwith user-owned HPC work directoriesTesting Steps:
UI Photos:
Notes: