Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2][Move] Fix flail/reversal damage formula #453

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Conversation

Tempo-anon
Copy link
Contributor

@Tempo-anon Tempo-anon commented Feb 8, 2025

Checkup

  • Documentation
  • No other bugs/issues

What are the changes the user will see?

Flail/Reversal now use the correct damage formula

Why am I making these changes?

Sam's original implementation was incorrect

What are the changes from a developer perspective?

  • Rewrote the logic in low-hp-power-attr
  • Created a flail.test

Screenshots/Videos

n/a

How to test the changes?

npm run test flail

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Tempo-anon Tempo-anon added Move For move implementations/interactions P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking. Checkup Part of an effort to ensure that moves/abilities/game features are functioning correctly. labels Feb 8, 2025
@frutescens
Copy link
Contributor

frutescens commented Feb 8, 2025

Could you write in the description if Flail has any other additional bugs or issues as of today? I don't think so, but it's worth confirming if this is going to be the move checkup issue for Flail.

Tempo-anon and others added 2 commits February 8, 2025 17:24
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
@frutescens frutescens merged commit 0437cd5 into beta Feb 8, 2025
7 checks passed
@frutescens frutescens deleted the flailReversal branch February 8, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Checkup Part of an effort to ensure that moves/abilities/game features are functioning correctly. Move For move implementations/interactions P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants