Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readded SmellYaLater as a possible release message #647

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

CodeTappert
Copy link
Contributor

@CodeTappert CodeTappert commented Feb 11, 2025

What are the changes the user will see?

SmellYaLater (or its translations) can be shown again when releasing a pokemon)

Why am I making these changes?

It was removed because of a missunderstanding/langauge barrier

What are the changes from a developer perspective?

Added it to the array of goodByeKeys

Screenshots/Videos

image

How to test the changes?

Release a pokemon until the message is shown

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@CodeTappert
Copy link
Contributor Author

Relevant Localization PR Despair-Games/poketernity-locales#16

But the message itself was already localized

@CodeTappert CodeTappert marked this pull request as ready for review February 11, 2025 21:19
@Tempo-anon Tempo-anon added the Localization Provides or updates translation efforts label Feb 11, 2025
@flx-sta flx-sta merged commit 47f0e5f into beta Feb 12, 2025
8 checks passed
@flx-sta flx-sta deleted the smellYaNow branch February 12, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants