Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkup] Super Luck documentation and tests #649

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

frutescens
Copy link
Contributor

What are the changes the user will see?

None.

Why am I making these changes?

An ability checkup a day...

What are the changes from a developer perspective?

  • Documentation and test added for Super Luck
  • Super Luck's ability attribute has been revised to take in a number of stages to boost and add that number to the ability holder's critical hit stages instead of changing a booleanholder's boolean to true. This makes the ability attribute BonusCritAbAttr much more self-evident in what it exactly does. In addition, this also matches how moves with a higher critical hit rate function in pokemon.getCritStages

How to test the changes?

npm run test super_luck

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?

@frutescens frutescens added the Checkup Part of an effort to ensure that moves/abilities/game features are functioning correctly. label Feb 12, 2025
@frutescens frutescens linked an issue Feb 12, 2025 that may be closed by this pull request
3 tasks
Tempo-anon
Tempo-anon previously approved these changes Feb 12, 2025
@frutescens frutescens mentioned this pull request Feb 12, 2025
3 tasks
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
flx-sta
flx-sta previously approved these changes Feb 12, 2025
@frutescens frutescens merged commit 7350eaf into beta Feb 12, 2025
8 checks passed
@frutescens frutescens deleted the superLuckCheckup branch February 12, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Checkup Part of an effort to ensure that moves/abilities/game features are functioning correctly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ability][Checkup] Super Luck
3 participants