[Checkup] Super Luck documentation and tests #649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
None.
Why am I making these changes?
An ability checkup a day...
What are the changes from a developer perspective?
BonusCritAbAttr
much more self-evident in what it exactly does. In addition, this also matches how moves with a higher critical hit rate function inpokemon.getCritStages
How to test the changes?
npm run test super_luck
Checklist
beta
as my base branchnpm run test:silent
)npm run create-test
) or updated existing tests related to the PR's changes?