Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3] Fix 'Can't release only valid pokemon' message #654

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

MokaStitcher
Copy link
Contributor

@MokaStitcher MokaStitcher commented Feb 12, 2025

What are the changes the user will see?

The message will show properly in game.

(Note that the UI theme names in the settings will no longer work since this updates the locale repo and the ui theme locale PR was merged without the main PR being ready)

Why am I making these changes?

PR #288 added the message but there was a typo in the key. Also the locale PR was never merged

What are the changes from a developer perspective?

  • fix key
  • update locale commit

Screenshots/Videos

image

@MokaStitcher MokaStitcher added P3 Bug Non gameplay affecting bug. Used for typos, graphical issues, or other minor incorrect interactions. Localization Provides or updates translation efforts labels Feb 12, 2025
@MokaStitcher MokaStitcher enabled auto-merge (squash) February 12, 2025 18:05
@MokaStitcher MokaStitcher merged commit 8b3f050 into beta Feb 12, 2025
8 checks passed
@MokaStitcher MokaStitcher deleted the fix-release-message branch February 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts P3 Bug Non gameplay affecting bug. Used for typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants