[Refactor][Misc] Cleaned up critical capture code. #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frutescens
added
Refactor
Tempo-anon
previously approved these changes
Feb 13, 2025
DayKev
previously approved these changes
Feb 14, 2025
innerthunder
previously approved these changes
Feb 14, 2025
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
frutescens
dismissed stale reviews from innerthunder, DayKev, and Tempo-anon
via
8f9599e
DayKev
previously approved these changes
Feb 16, 2025
MokaStitcher
approved these changes
Feb 16, 2025
DayKev
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
None.
Why am I making these changes?
With this codebase, there's moments where you open a random file and see a stupid, chunky ternary.
What are the changes from a developer perspective?
Ternary broken up into if-else statements for better readability.
How to test the changes?
Critical Captures should work as expected.
Checklist
betaas my base branchnpm run test:silent)npm run create-test) or updated existing tests related to the PR's changes?