Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix flaky Rage test #668

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[Test] Fix flaky Rage test #668

merged 2 commits into from
Feb 14, 2025

Conversation

PigeonBar
Copy link
Contributor

Why am I making these changes?

The test could break due to the player Pokemon occasionally fainting.

What are the changes from a developer perspective?

The test now sets the player Pokemon's Defense to +6 stages to prevent it from fainting.

Screenshots/Videos

How to test the changes?

Check that the player Pokemon still survives if you override the opponents to have max IV's and a higher level.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent

frutescens
frutescens previously approved these changes Feb 13, 2025
@PigeonBar PigeonBar enabled auto-merge (squash) February 14, 2025 00:36
Tempo-anon
Tempo-anon previously approved these changes Feb 14, 2025
Copy link
Contributor

@Tempo-anon Tempo-anon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me clean up my unit test 😭

@Tempo-anon Tempo-anon added the Tests Automated tests related label Feb 14, 2025
@PigeonBar PigeonBar dismissed stale reviews from Tempo-anon and frutescens via 104e951 February 14, 2025 01:01
@PigeonBar PigeonBar merged commit 1bdf2c4 into beta Feb 14, 2025
8 checks passed
@PigeonBar PigeonBar deleted the fix-rage-test branch February 14, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Automated tests related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants