Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3][Beta] Fix settings showing wrong number of window types #682

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

MokaStitcher
Copy link
Contributor

What are the changes the user will see?

Only 5 window types to choose from instead of 10

Why am I making these changes?

Messed up when trying to get the length of an enum in #419

What are the changes from a developer perspective?

use the utils function getEnumLength

Screenshots/Videos

Before/After
image
image

How to test the changes?

Settings > Display tab

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run test:create) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (dark and light)?

Are there any localization additions or changes? If so:

@MokaStitcher MokaStitcher added P3 Bug Non gameplay affecting bug. Used for typos, graphical issues, or other minor incorrect interactions. Beta Only present on Beta (didn't make it into production [yet]) labels Feb 15, 2025
Copy link
Contributor

@frutescens frutescens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have 10 window types though

@MokaStitcher MokaStitcher merged commit 8cca5cd into beta Feb 15, 2025
8 checks passed
@MokaStitcher MokaStitcher deleted the window-type-setting-fix branch February 15, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Only present on Beta (didn't make it into production [yet]) P3 Bug Non gameplay affecting bug. Used for typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants