switch from lerna to npm workspaces #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetachHead
force-pushed
the
npm-workspaces
branch
3 times, most recently
from
b254511 to
1d9a4d1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DetachHead
force-pushed
the
npm-workspaces
branch
from
77c9d2c to
5239c20
Compare
This comment has been minimized.
This comment has been minimized.
…but the tests explicitly import it
…pm uses the top-level lockfile for all workspace packages
…ly on upstream to bump npm deps so we don't need these scripts anyway
…anymore since all dependencies are now installed to the top level `node_modules`
…allow multiple packages with the same name
…ng other than the project root
DetachHead
force-pushed
the
npm-workspaces
branch
from
5239c20 to
4b1af74
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
- Type of "expand" is "Unknown | ((**kwargs: Unknown) -> Equality) | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality) | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Integral))" (reportUnknownMemberType)
+ Type of "expand" is "Unknown | ((**kwargs: Unknown) -> Equality) | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality) | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr))" (reportUnknownMemberType)
- Argument type is "Unknown | Order | Any | Integral | Equality | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Unknown | Order | Any | Self@Expr | Equality | Relational | Unequality" (reportUnknownArgumentType)
- Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality) | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Sum))" (reportUnknownMemberType)
+ Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality) | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr))" (reportUnknownMemberType)
- Argument type is "Unknown | Order | Any | Sum | Equality | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Unknown | Order | Any | Self@Expr | Equality | Relational | Unequality" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/simplify/tests/test_sqrtdenest.py:123:5 - warning: Type of "z1" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/simplify/tests/test_sqrtdenest.py:123:5 - warning: Type of "z1" is partially unknown
+ Type of "z1" is "Unknown | Mul | Pow | Order | Expr | Add | None" (reportUnknownVariableType)
- Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any))" (reportUnknownMemberType)
+ Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr))" (reportUnknownMemberType)
- Type of "i_part" is "Unknown | Order | Any" (reportUnknownVariableType)
+ Type of "i_part" is "Unknown | Order | Any | Self@Expr" (reportUnknownVariableType)
- Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any)) | Any" (reportUnknownMemberType)
+ Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr)) | Any" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:21 - warning: Type of "b" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:21 - warning: Type of "b" is partially unknown
+ Type of "b" is "Mul | Unknown | Integer | Expr" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:24 - warning: Type of "e" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:24 - warning: Type of "e" is partially unknown
+ Type of "e" is "Unknown | Expr | Mul | None" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:28 - warning: Type of "as_base_exp" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:28 - warning: Type of "as_base_exp" is partially unknown
+ Type of "as_base_exp" is "Unknown | (() -> (tuple[Mul, Unknown] | tuple[Mul, Expr | None])) | (() -> (tuple[Unknown | Integer, Unknown | Mul] | tuple[Expr, Expr])) | (() -> tuple[Expr, Expr])" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2788:44 - error: "as_base_exp" is not a known attribute of "None" (reportOptionalMemberAccess)
- Type of "check" is "list[Unknown]" (reportUnknownVariableType)
+ Type of "check" is "list[Unknown | Mul | Pow | Order | Expr | Add | None]" (reportUnknownVariableType)
- Type of "extend" is "(iterable: Iterable[Unknown], /) -> None" (reportUnknownMemberType)
+ Type of "extend" is "(iterable: Iterable[Unknown | Mul | Pow | Order | Expr | Add | None], /) -> None" (reportUnknownMemberType)
- Type of "extend" is "(iterable: Iterable[Unknown], /) -> None" (reportUnknownMemberType)
+ Type of "extend" is "(iterable: Iterable[Unknown | Mul | Pow | Order | Expr | Add | None], /) -> None" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2793:21 - warning: Type of "s" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2793:21 - warning: Type of "s" is partially unknown
+ Type of "s" is "Unknown | Mul | Pow | Order | Expr | Add | None" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2794:44 - warning: Argument type is unknown
- Argument corresponds to parameter "sol" in function "checksol" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/solvers.py:2798:36 - warning: Argument type is unknown
- Argument corresponds to parameter "object" in function "append" (reportUnknownArgumentType)
- Type of "g" is "Unknown | Order | Any" (reportUnknownVariableType)
+ Type of "g" is "Unknown | Order | Any | Self@Expr" (reportUnknownVariableType)
- Type of "h" is "Unknown | Order | Any" (reportUnknownVariableType)
+ Type of "h" is "Unknown | Order | Any | Self@Expr" (reportUnknownVariableType)
- Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any))" (reportUnknownMemberType)
+ Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr))" (reportUnknownMemberType)
- Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any))" (reportUnknownMemberType)
+ Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr))" (reportUnknownMemberType)
- Type of "g" is "Unknown | Order | Basic | Any" (reportUnknownVariableType)
+ Type of "g" is "Unknown | Order | Basic | Self@Expr | Any" (reportUnknownVariableType)
- Type of "h" is "Unknown | Order | Basic | Any" (reportUnknownVariableType)
+ Type of "h" is "Unknown | Order | Basic | Self@Expr | Any" (reportUnknownVariableType)
- Type of "subs" is "Unknown | ((...) -> (Unknown | Order | Basic)) | Any" (reportUnknownMemberType)
+ Type of "subs" is "Unknown | ((...) -> (Unknown | Order | Basic)) | Any | ((...) -> (Unknown | Self@Expr | Basic))" (reportUnknownMemberType)
- Type of "subs" is "Unknown | ((...) -> (Unknown | Order | Basic)) | Any" (reportUnknownMemberType)
+ Type of "subs" is "Unknown | ((...) -> (Unknown | Order | Basic)) | Any | ((...) -> (Unknown | Self@Expr | Basic))" (reportUnknownMemberType)
- Type of "g" is "Unknown | Order | Any" (reportUnknownVariableType)
+ Type of "g" is "Unknown | Order | Any | Self@Expr" (reportUnknownVariableType)
- Type of "h" is "Unknown | Order | Any" (reportUnknownVariableType)
+ Type of "h" is "Unknown | Order | Any | Self@Expr" (reportUnknownVariableType)
- Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any))" (reportUnknownMemberType)
+ Type of "expand" is "Unknown | ((deep: bool = True, modulus: Unknown | None = None, power_base: bool = True, power_exp: bool = True, mul: bool = True, log: bool = True, multinomial: bool = True, basic: bool = True, **hints: Unknown) -> (Unknown | Order | Any | Self@Expr))" (reportUnknownMemberType)
... (truncated 3712 lines) ...
spack (https://github.com/spack/spack)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skilion-onedrive/package.py:20:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skilion-onedrive/package.py:21:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skilion-onedrive/package.py:22:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skilion-onedrive/package.py:20:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skilion-onedrive/package.py:21:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skilion-onedrive/package.py:22:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:25:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:25:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:27:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:27:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:28:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:28:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:29:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:29:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:30:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:30:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:31:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:31:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:32:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/skopeo/package.py:32:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/sl/package.py:19:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/sl/package.py:19:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/sl/package.py:21:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/sl/package.py:21:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slang/package.py:21:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slang/package.py:21:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:57:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:57:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:58:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:58:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:59:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:59:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:71:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:71:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:73:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:73:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
- /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:74:5 - warning: Result of call expression is of type "((pkg: PackageBase) -> None)" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/slate/package.py:74:5 - warning: Result of call expression is of type "(pkg: PackageBase) -> None" and is not used; assign to variable "_" if this is intentional (reportUnusedCallResult)
... (truncated 4476 lines) ...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of lerna/lerna#4094