Check for SIGHUP #78
Check for SIGHUP #78
Conversation
src/platform/unix/mod.rs
Outdated
| match signal::sigaction(signal::Signal::SIGHUP, &new_action) { | ||
| Ok(_) => {} | ||
| Err(e) => { | ||
| signal::sigaction(signal::Signal::SIGINT, &_old).unwrap(); |
There was a problem hiding this comment.
Old value for SIGTERM should be reverted in this cleanup function. Also, the variable _old should be named old now as it is being used. Maybe assign current _old to sigint_old and introduce sigterm_old.
There was a problem hiding this comment.
I made a change. Is that maybe what you have in mind?
|
I took another look at https://en.wikipedia.org/wiki/Signal_(IPC)#POSIX_signals and found this other signal:
This should probably be handled as well to ensure a graceful termination whenever possible. Do you see anything else that might be worth checking for on the article? Maybe |
I don't think |
|
@Detegr I made some changes and tested it. Do you mind taking a look again? |
|
Done. |
If you have the
terminationfeature enabled and close the terminal (its window) with the X button,SIGHUPis sent to the process butctrlcdoesn't handle it so no graceful shutdown is done in that case but I would expect theterminationfeature to be able to detect that because pressing the X button to terminate an application is definitely a common kind of termination. Also, I believe on Windows this already works because when the window is X-ed,CTRL_CLOSE_EVENTis sent whichctrlcseems to handle. This means on Windows, the handler is invoked on X but on Linux (and very likely macOS), it is not. So this fixes inconsistent behavior.