Make fh list releases more granular
#200
Conversation
WalkthroughBumps crate version and updates multiple Cargo dependency signatures (features/default-features and one removal); replaces CLI list row types with a Tabled-backed Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI as "cli::cmd::list"
participant Tabled as "tabled renderer"
participant Chrono as "chrono::DateTime<Utc>"
User->>CLI: run list command
CLI->>CLI: collect Release items (fields incl. optional datetimes)
CLI->>Tabled: pass Vec<Release>
Tabled->>Chrono: request formatting for Option<DateTime<Utc>>
Chrono-->>Tabled: formatted date or empty
Tabled-->>User: render table / JSON / CSV
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)src/cli/cmd/list.rs (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/cli/cmd/list.rs (3)
91-105: Ensure API field names match — otherwise deserialization will fail.
Releasenow (de)serializes directly. If the FlakeHub API uses different casing (e.g., camelCase), add appropriate serde renames or a struct-level#[serde(rename_all = "...")].If you require RFC3339 for JSON, add per-field helpers, e.g.,
#[serde(with = "chrono::serde::ts_rfc3339::option")]forpublished_at/updated_at. Based on learnings
107-114: Optional: include timezone indicator in formatted timestamps.Current table output omits ‘Z/UTC’. Consider appending “Z” or using RFC3339 for clarity.
251-267: Output routing is correct; verify default CSV headers align withReleasefields
- JSON prints raw
Releasevia serde.- TTY → table; non-TTY → CSV matches other commands.
- If header stability matters, confirm
csv::Writer’s default header names/order.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
Cargo.toml(1 hunks)src/cli/cmd/list.rs(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/cli/cmd/list.rs (1)
src/cli/cmd/mod.rs (2)
releases(133-136)print_json(295-299)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-artifacts (x86_64-darwin, macos-14-large, fh-X64-macOS)
- GitHub Check: build-artifacts (x86_64-linux, ubuntu-22.04, fh-ARM64-linux)
- GitHub Check: build-artifacts (aarch64-darwin, macos-latest-xlarge, fh-ARM64-macOS)
- GitHub Check: build-artifacts (aarch64-linux, namespace-profile-default-arm64, fh-X64-Linux)
- GitHub Check: rust-fmt-and-clippy
🔇 Additional comments (4)
Cargo.toml (2)
3-3: Patch version bump looks good.No concerns.
11-14: Enablingchrono’sserdeis the right move for DateTime fields.Confirm downstream expects the chosen JSON date format (Chrono default). If a specific format is required (e.g., RFC3339), consider adding explicit serde helpers at the field sites.
Based on learnings
src/cli/cmd/list.rs (2)
1-1: Chrono import aligns with new DateTime fields.Good addition.
115-120: Helper looks fine.Returns dimmed text for Some and empty for None — OK.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/cli/cmd/list.rs (1)
108-112: Keep the timezone in release timestamps.Formatting with
%Y-%m-%d %H:%Mdrops theUTCsuffix, so the table output looks like local time while the JSON still advertisesZ. Keeping the zone avoids confusion.- Some(dt) => dt.format("%Y-%m-%d %H:%M").to_string(), + Some(dt) => dt.format("%Y-%m-%d %H:%M %Z").to_string(),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockflake.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
Cargo.toml(1 hunks)src/cli/cmd/list.rs(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/cli/cmd/list.rs (1)
src/cli/cmd/mod.rs (2)
releases(133-136)print_json(295-299)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-artifacts (x86_64-linux, ubuntu-22.04, fh-ARM64-linux)
- GitHub Check: build-artifacts (x86_64-darwin, macos-14-large, fh-X64-macOS)
- GitHub Check: build-artifacts (aarch64-linux, namespace-profile-default-arm64, fh-X64-Linux)
- GitHub Check: rust-fmt-and-clippy
- GitHub Check: build-artifacts (aarch64-darwin, macos-latest-xlarge, fh-ARM64-macOS)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/cli/cmd/list.rs (1)
108-113: Consider preserving timezone in formatted timestamps.
Line 110 formats timestamps as%Y-%m-%d %H:%M, dropping seconds and the UTC designator. For global release data, including the timezone (e.g., viadt.to_rfc3339()or%Z) would make it clearer that the values are UTC.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockflake.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
Cargo.toml(1 hunks)src/cli/cmd/list.rs(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/cli/cmd/list.rs (1)
src/cli/cmd/mod.rs (2)
releases(133-136)print_json(295-299)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-artifacts (x86_64-darwin, macos-14-large, fh-X64-macOS)
- GitHub Check: build-artifacts (aarch64-linux, namespace-profile-default-arm64, fh-X64-Linux)
- GitHub Check: build-artifacts (x86_64-linux, ubuntu-22.04, fh-ARM64-linux)
- GitHub Check: build-artifacts (aarch64-darwin, macos-latest-xlarge, fh-ARM64-macOS)
- GitHub Check: rust-fmt-and-clippy
1 participant
Currently this returns the bare minimum for a release:
{ "Version": "1.2.3" }Now it's more robust but without including almost always duplicated fields like
description,readme, andtotal.{ "simplified_version": "0.1.25", "version": "0.1.25", "revision": "e3b574c59803ee6b240b6a92b7ebb41a51d8cbcc", "published_at": "2025-08-06T01:15:25.753285Z", "updated_at": "2025-08-06T01:15:25.668616Z", "commit_count": 745 }Summary by CodeRabbit
New Features
Improvements
Chores