Emit an attribute for legacyPackages that fail to evaluate #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucperkins
approved these changes
Jul 1, 2024
cole-h
reviewed
Jul 1, 2024
| [ ]) | ||
| [{ | ||
| name = attrName; | ||
| value = throw "failed"; |
There was a problem hiding this comment.
I wonder if there's a way to reuse the error that would have occurred if we recursed here, so that it's not just a context-less "failed"?
There was a problem hiding this comment.
Not easily. We could do something like value = ... whatever value caused the error ... but that's a bit error-prone. Maybe something like
value = assert attrs.type != null; throw "failed";
E.g. AAAAAASomeThingsFailToEvaluate in Nixpkgs.
edolstra
force-pushed
the
show-failed-legacy-packages
branch
from
a9cac93
to
042afa6
Compare
edolstra
added a commit
to DeterminateSystems/nix-src
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
AAAAAASomeThingsFailToEvaluatein Nixpkgs. This fixes a test in Nix's test suite.