Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add homeModules schema #30

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Add homeModules schema #30

merged 2 commits into from
Jul 26, 2024

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented Jul 25, 2024 •
edited
Loading

This appears to be a very commonly used construct: https://github.com/search?q=homemanagermodules&type=code

grahamc
grahamc reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HomeManager (and Nix) prefers homeModules, but otherwise lgthm

@lucperkins
Copy link
Member Author

lucperkins commented Jul 25, 2024 •
edited
Loading

@grahamc Okay, I've switched to homeModules. Perhaps we can consider supporting both upon request.

@lucperkins lucperkins changed the title Add homeManagerModules schema Add homeModules schema Jul 25, 2024
@lucperkins lucperkins requested a review from grahamc July 25, 2024 19:52
@grahamc grahamc merged commit 0a5c422 into main Jul 26, 2024
1 check passed
@grahamc grahamc deleted the home-manager-modules branch July 26, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucperkins @grahamc