Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tsup-based build #44

Merged
merged 11 commits into from
Apr 21, 2024
Merged

Switch to tsup-based build #44

merged 11 commits into from
Apr 21, 2024

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented Apr 20, 2024

This updates the Action to use tsup to compile TS to JS.

Note: I'm marking this as a draft because DeterminateSystems/detsys-ts#18 needs to be merged first.

@lucperkins lucperkins requested a review from grahamc April 20, 2024 23:59
@lucperkins lucperkins marked this pull request as draft April 21, 2024 15:46
@grahamc
Copy link
Member

grahamc commented Apr 21, 2024

Hm... why do we have an index.js and a main.js in the dist dir now? Should we update action.yml to point to main.js? https://github.com/DeterminateSystems/magic-nix-cache-action/blob/main/action.yml#L57-L58

@lucperkins
Copy link
Member Author

@grahamc Fixed

@lucperkins lucperkins marked this pull request as ready for review April 21, 2024 16:47
@grahamc grahamc merged commit 6718417 into main Apr 21, 2024
5 checks passed
@grahamc grahamc deleted the tsup-build branch April 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants