Graham/fh 433 magic nix cache should disable GitHub actions cache when flakehub cache is enabled #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght bool for the moment
…, and flakehub cache is in use
colemickens
approved these changes
Nov 6, 2024
grahamc
deleted the
graham/fh-433-magic-nix-cache-should-disable-github-actions-cache-if
branch
cole-h
reviewed
Nov 6, 2024
| @@ -72,7 +72,7 @@ jobs: | |||
| uses: DeterminateSystems/nix-installer-action@main | |||
|
|
|||
| - name: Test magic-nix-cache-action@main on ${{ matrix.systems.runner }} | |||
| uses: DeterminateSystems/magic-nix-cache-action@main | |||
| uses: DeterminateSystems/magic-nix-cache-action@graham/fh-433-magic-nix-cache-should-disable-github-actions-cache-if | |||
There was a problem hiding this comment.
Not sure we want to have this branch be used in production...? If it gets deleted, runs will start failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, the Github Actions cache is a less good experience than FlakeHub Cache. Using FHC + GHA makes for a less stellar experience. This PR makes it by default use only FHC if FHC is available, but allows a user to explicitly turn-on GHA in addition.