Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for disabling closure computation in GHA cache #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yfyf
Copy link

@yfyf yfyf commented Nov 22, 2024

Allows to only cache the built derivations without their closures.

This avoids polluting the GHA cache with many duplicate entries, which happens when a downstream derivation changes (and is rebuilt), but its dependencies don't (but would get pushed to the cache each time regardless).

Should reduce the impact of issues like #75.

Not sure how to test this properly, but verified manually that OUT_PATHS=$(which bash) ./target/debug/magic-nix-cache --no-closure enqueues only the bash NAR.

Allows to only cache the built derivations without their closures.

This avoids polluting the GHA cache with many duplicate entries, which
happens when a downstream derivation changes (and is rebuilt), but
its dependencies don't (but would get pushed to the cache each time
regardless).
@yfyf
Copy link
Author

yfyf commented Nov 22, 2024

Amended the commit after cargo fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant