Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_default_profile: don't substitute #1101

Merged
merged 2 commits into from
Aug 19, 2024
Merged

setup_default_profile: don't substitute #1101

merged 2 commits into from
Aug 19, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Aug 19, 2024

We already have everything we need, so substitution is not necessary
(and makes it slower in our VM tests without networking).

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

We already have everything we need, so substitution is not necessary
(and makes it slower in our VM tests without networking).
This should always be a local build.
@cole-h cole-h enabled auto-merge (squash) August 19, 2024 17:43
@cole-h cole-h merged commit f94502d into main Aug 19, 2024
20 checks passed
@cole-h cole-h deleted the dont-substitute branch August 19, 2024 18:01
@cole-h cole-h added this to the 0.21.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants