Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaceNixConfiguration: fix --extra-conf handling of extra-trusted-substituters and extra-trusted-public-keys #1145

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Sep 6, 2024

Description

Fixes #1133.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@cole-h cole-h added this to the 0.25.0 milestone Sep 6, 2024
@cole-h cole-h added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Sep 6, 2024
…ted-public-keys` and `extra-trusted-substituters`

This will fail until a follow-up commit that fixes it.
…substituters` and `extra-trusted-public-keys`
@cole-h cole-h changed the title Fix --extra-conf handling of extra-trusted-substituters and extra-trusted-public-keys PlaceNixConfiguration: fix --extra-conf handling of extra-trusted-substituters and extra-trusted-public-keys Sep 6, 2024
@donn
Copy link

donn commented Sep 10, 2024

Wait, why didn't this make it into 0.25.0?

@cole-h cole-h modified the milestones: 0.25.0, 0.25.1 Sep 10, 2024
@cole-h
Copy link
Member Author

cole-h commented Sep 10, 2024

We got in a bit of a tizzy trying to get a release out with the Nix update and this got forgotten about in the heat of the moment. My apologies, but rest assured, it'll make it into the next release.

@cole-h cole-h merged commit 7ed9e26 into main Sep 10, 2024
21 checks passed
@cole-h cole-h deleted the fix-extra-conf branch September 10, 2024 14:19
@grahamc
Copy link
Member

grahamc commented Sep 10, 2024

@donn We have a handful of updates we're wanting to get out in the next couple days. We've recently adopted a policy to generally release installer changes separately from nix-installer changes, to reduce the likelihood of an issue with one blocking the release of the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix-installer install --extra-conf cannot set extra-trusted-substituters and extra-trusted-public-keys
3 participants