Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootout errors on macOS once and for all #1257

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Fix bootout errors on macOS once and for all #1257

merged 10 commits into from
Oct 31, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Oct 28, 2024 •
edited
Loading

...I hope.

Also includes some cleanups that makes life better.

Description

Fixes #1234.
Fixes #1230.
Fixes #1209.
Fixes #1187.
Fixes #1172.
Fixes #1168.
Fixes #1078.
Fixes #926.
Fixes #892.

Workaround if you run into this issue before this PR is released:

sudo launchctl bootout system/systems.determinate.nix-installer.nix-hook
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@cole-h cole-h added the MacOS Darwin/MacOS label Oct 28, 2024
@cole-h
ConfigureInitService: remove unnecessary systemctl daemon-reload
d7f1961
@cole-h
ConfigureInitService: don't remove files that were already removed
e1470e7
@cole-h
ConfigureDeterminateNixdInitService: remove unused error enum
8d25332
@cole-h
ConfigureInitService: don't check if units already exist
8742799 
If they do, we'll replace them in the execute step anyways.
@cole-h
ConfigureInitService: fixup tracing log line outside of guard
7e6648f
@cole-h
fixup: rename restore_shell variable to repair
5b8b632
@cole-h
ConfigureInitService: bootout failure is (probably) not fatal, just c…
809df7c 
…ollect it and move on
@cole-h
fixup: const-ify selinux policy path for FHS systems
33bd4fc
@cole-h
retry_bootout: use service identifier for bootout instead of path
e6e5cbc 
Hopefully fixes the "Boot-out failed: 5: Input/output error" error on
all future installs.
@cole-h
fixup: deduplicate service_name
cea743c
This was referenced Oct 28, 2024
Closed
Closed
Merged
@cole-h cole-h merged commit bbb9394 into main Oct 31, 2024
21 checks passed
@cole-h cole-h deleted the fix-bootout-failures branch October 31, 2024 16:02
This was referenced Nov 4, 2024
Closed
Closed
Closed
@cole-h cole-h added this to the 0.28.0 milestone Nov 8, 2024
This was referenced Nov 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
MacOS Darwin/MacOS
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

<autogenerated-issue> Remove file /Library/LaunchDaemons/systems.determinate.nix-installer.nix-hook.plist 2: No such file or directory (os error 2) Boot-out failed: 5: Input/output error on systems.determinate.nix-installer.nix-hook <autogenerated-issue> <autogenerated-issue> Can't install nix. Error in create nix volume
"launchctl" "bootout" "system" "/Library/LaunchDaemons/systems.determinate.nix-installer.nix-hook.plist" Boot-out failed: 5: Input/output error "launchctl" "bootout" "system" "/Library/LaunchDaemons/org.nixos.darwin-store.plist" Boot-out failed: 5: Input/output error plist file is never created but the installer assumes it is "launchctl" "bootout" "system" "/Library/LaunchDaemons/org.nixos.darwin-store.plist" Boot-out failed: 2: No such file or directory
2 participants
@cole-h @grahamc