Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about a CI API call reduction? #245

Merged
merged 17 commits into from
Feb 14, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Try to reduce the rate limiting issues we get on the Mac runners by reducing the amount we used Github Actions or their API at all.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 10, 2023
@Hoverbear Hoverbear added this to the v0.3.0 milestone Feb 10, 2023
@Hoverbear Hoverbear removed this from the v0.3.0 milestone Feb 10, 2023
@Hoverbear
Copy link
Contributor Author

Hoverbear commented Feb 10, 2023

Macs continue to exist, however container actions aren't supported on them. Will have to explore alternatives.

@Hoverbear Hoverbear added the blocked The PR is blocked by something label Feb 10, 2023
@Hoverbear
Copy link
Contributor Author

Hoverbear commented Feb 13, 2023

So we'd need to load the cache from the linux runner and make the mac runner happen after.

image

@Hoverbear Hoverbear removed the blocked The PR is blocked by something label Feb 13, 2023
@Hoverbear Hoverbear marked this pull request as draft February 13, 2023 20:06
@Hoverbear Hoverbear marked this pull request as ready for review February 14, 2023 15:45
@Hoverbear Hoverbear added this to the v0.3.0 milestone Feb 14, 2023
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I did mostly skim because YAML diffs are quite possibly the ugliest things to look at.

@Hoverbear Hoverbear merged commit 6ec5080 into main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants