Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't parallelize user creation #260

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Don't parallelize user creation #260

merged 1 commit into from
Feb 19, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

I've seen it break on a few distros now and we don't want that for users.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 17, 2023
@Hoverbear Hoverbear added this to the v0.3.1 milestone Feb 17, 2023
@Hoverbear Hoverbear changed the title Don't parallize user creation Don't parallelize user creation Feb 17, 2023
@Hoverbear Hoverbear marked this pull request as ready for review February 17, 2023 22:10
@Hoverbear Hoverbear requested a review from cole-h February 17, 2023 22:12
cole-h
cole-h reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good, but I do have one question.

src/action/common/create_users_and_groups.rs Show resolved Hide resolved
@Hoverbear Hoverbear merged commit a89e05b into main Feb 19, 2023
@Hoverbear Hoverbear deleted the dont-parallize-user-creation branch February 19, 2023 00:56
@lucperkins lucperkins mentioned this pull request Feb 20, 2023
Merged
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h