Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newline to end of plan json output #283

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Add newline to end of plan json output #283

merged 3 commits into from
Feb 28, 2023

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 28, 2023

This causes some shells (like sh) to continue their prompt right after
the closing brace, which is kinda meh.##### Description

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@cole-h
Add newline to end of plan json output
8f4e4a5 
This causes some shells (like sh) to continue their prompt right after
the closing brace, which is kinda meh.
@cole-h
Add newline to end of receipt.json
b48600f 
`cat /nix/receipt.json` has the same issue as the previous commit, in
that it will bleed into the prompt for some shells that don't insert an
implicit newline.
@cole-h
Add newline to end of fixture json documents
ac216eb
@cole-h cole-h added this to the v0.4.1 milestone Feb 28, 2023
@cole-h cole-h self-assigned this Feb 28, 2023
@Hoverbear Hoverbear merged commit 9c8284c into main Feb 28, 2023
@Hoverbear Hoverbear deleted the newline-at-end-of-plan branch February 28, 2023 16:38
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

Assignees

@cole-h cole-h

Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-h @Hoverbear