Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default nix_package_url to Nix 2.14.1 #286

Closed
wants to merge 2 commits into from
Closed

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 28, 2023

Description

2.14.0 was released today.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Drafted until NixOS/nix#7920 NixOS/nix#7925 is resolved, as that could break some CI machines.

@cole-h cole-h self-assigned this Feb 28, 2023
@Hoverbear
Copy link
Contributor

I restarted the buildkite jobs that failed

Copy link

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.14.1 has been released in the meantime: https://github.com/NixOS/nix/releases/tag/2.14.1

@cole-h
Copy link
Member Author

cole-h commented Mar 6, 2023

I'm personally waiting on seeing how NixOS/nix#7984 shakes out before marking this as ready-for-review. Despite being flakes-first, there are still people who use the legacy CLI with this installer (i.e. #234). I know that at the very least nix-env -iA nixpkgs.hello is broken as of 2.14.1 directly after a multi-user install (though this can be fixed with a couple nix-channel invocations, it's difficult to do that automatically since users don't fall back to root's channels anymore it seems).

@cole-h
Copy link
Member Author

cole-h commented Mar 8, 2023

Note to self: make sure #304 is still fine after we bump to 2.14.

@cole-h cole-h changed the title Update default nix_package_url to Nix 2.14.0 Update default nix_package_url to Nix 2.14.1 Mar 8, 2023
@cole-h cole-h added the blocked The PR is blocked by something label Mar 10, 2023
@cole-h cole-h mentioned this pull request Apr 25, 2023
6 tasks
@cole-h cole-h deleted the update-nix branch May 1, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The PR is blocked by something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants