Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curing existing /nix #310

Merged
merged 7 commits into from
Mar 8, 2023
Merged

Curing existing /nix #310

merged 7 commits into from
Mar 8, 2023

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Mar 7, 2023 •
edited
Loading

Description

This gets us a lot of the ways towards #126 , closes #309:

image

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Mar 7, 2023
@Hoverbear Hoverbear marked this pull request as ready for review March 8, 2023 16:54
@Hoverbear Hoverbear requested a review from cole-h March 8, 2023 16:54
@Hoverbear Hoverbear added this to the v0.6.0 milestone Mar 8, 2023
cole-h
cole-h reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also, conflicts with main)

src/action/base/setup_default_profile.rs Outdated Show resolved Hide resolved
src/action/base/setup_default_profile.rs Outdated Show resolved Hide resolved
src/action/base/setup_default_profile.rs Outdated Show resolved Hide resolved
src/cli/subcommand/install.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear requested a review from cole-h March 8, 2023 18:08
cole-h
cole-h reviewed Mar 8, 2023
View reviewed changes
src/action/mod.rs Outdated Show resolved Hide resolved
src/cli/subcommand/install.rs Show resolved Hide resolved
@Hoverbear Hoverbear enabled auto-merge (squash) March 8, 2023 18:32
@Hoverbear Hoverbear merged commit 85abfc3 into main Mar 8, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-700-curing-existing-nix branch March 8, 2023 18:43
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Curing exisiting /nix folders
2 participants
@Hoverbear @cole-h