In the README, recommend a git url #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Mar 16, 2023
| @@ -266,7 +266,7 @@ Then copy the `result/bin/nix-installer` to the machine you wish to run it on. | |||
| You can also add `nix-installer` to a system without Nix via `cargo`: | |||
|
|
|||
| ```bash | |||
| RUSTFLAGS="--cfg tokio_unstable" cargo install nix-installer | |||
| RUSTFLAGS="--cfg tokio_unstable" cargo install --git https://github.com/DeterminateSystems/nix-installer | |||
There was a problem hiding this comment.
I'm not so sure we want this to be the "default" recommendation...? Maybe add a note like "if you want to try the most recent, not-yet-released changes, you can also install directly from git with: ...."
There was a problem hiding this comment.
Oh, maybe. We should do that with the nix flake ref too then
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of our users was kind enough to test a PR for us! They did it by building their own binary with Cargo! This is excellent and it seems to have worked fine for them. I did notice they seem to have
git cloned the repo before, which they didn't need to do! We can recommend future users use a git address to help them skip a step.Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: