-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre install/uninstall checks to planners #561
Merged
Hoverbear
merged 9 commits into
main
from
hoverbear/ds-1001-add-preinstallpreuninstall-checks-to-planners
Jul 12, 2023
Merged
Add pre install/uninstall checks to planners #561
Hoverbear
merged 9 commits into
main
from
hoverbear/ds-1001-add-preinstallpreuninstall-checks-to-planners
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
added
the
upload to s3
The labeled PR is allowed to upload its artifacts to S3 for easy testing
label
Jul 11, 2023
cole-h
reviewed
Jul 11, 2023
cole-h
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good!
Hoverbear
deleted the
hoverbear/ds-1001-add-preinstallpreuninstall-checks-to-planners
branch
July 12, 2023 16:08
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add structured pre install/uninstall planner steps to mitigate users encountering #528.
Testing
Create a
flake.nix
with these contents in some folder (mine isboop
, thencd
in:Doing the rest:
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: