Save expire and last-modified Http cache headers #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the crawler to act better (in the future) with http cache.
This allows pingback handlers to validate that algolia's new saved value is properly up to date.
fhamon
reviewed
Nov 23, 2018
PascalPiche
approved these changes
Nov 26, 2018
| @@ -35,6 +35,7 @@ module.exports = (config) => { | |||
| result: data.result, | |||
| action: data.action, | |||
| url: data.url, | |||
| 'last-modified': data.lastModified, | |||
There was a problem hiding this comment.
its the only one quoted. we should quote all other for consistency
There was a problem hiding this comment.
or maybe use camel-case?
There was a problem hiding this comment.
Well, I preferred to use the "spec'ed" spelling...
fhamon
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And send them to pingback upon successful update