Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Incorrect behaviour of "selection_mode" #72

Closed
DevAhamed opened this issue May 3, 2019 · 1 comment
Closed

Incorrect behaviour of "selection_mode" #72

DevAhamed opened this issue May 3, 2019 · 1 comment
Labels
2.x Version - Issues related to 2.x version 3.x Version - Issues related to 3.x version component-core Component - Issues related to core adapter library type:bug
Milestone
2.0.0

Comments

@DevAhamed
Copy link
Owner

Information Needed:

  • Android API level: 21
  • Library Version: 2.0.0-alpha01
  • Recyclerview Version: 28.0.0

What:
When adapter has selection mode as 'Multiple' and sections has selection mode as 'Single', adapter behaves as if the selection mode was 'Single'

Steps to reproduce:

  1. Install sample app, goto 'selection' demo screen
  2. Set adapter selection mode as 'Multiple' and set selection mode as 'Single' for all the sections.
  3. Select an item in section 1 and select an item in section 2.
  4. Notice how the section 1 item is unselected. This is a behaviour of 'Single' mode, but it should not be the case since adapter has 'Multiple'
@DevAhamed DevAhamed added type:bug 2.x Version - Issues related to 2.x version 3.x Version - Issues related to 3.x version component-core Component - Issues related to core adapter library labels May 3, 2019
@DevAhamed DevAhamed added this to the 2.0.0-rc milestone May 3, 2019
DevAhamed added a commit that referenced this issue May 3, 2019
@DevAhamed
Fixes incorrect 'selection' and 'expansion' behaviour
3b073a4 
When the sections have selection/expansion mode as single and adapter has mode as multiple, then incorrect mode is set for adapter. This is discussed in this issue #72.
DevAhamed added a commit that referenced this issue May 3, 2019
@DevAhamed
Fixes incorrect 'selection' and 'expansion' behaviour
17f9538 
When the sections have selection/expansion mode as single and adapter has mode as multiple, then incorrect mode is set for adapter. This is discussed in this issue #72. Same issue has been fixed in 2.x branch as well.
@DevAhamed DevAhamed mentioned this issue May 3, 2019
Merged
DevAhamed added a commit that referenced this issue May 3, 2019
@DevAhamed
Fixes incorrect 'selection' and 'expansion' behaviour (#73)
7fedd55 
When the sections have selection/expansion mode as single and adapter has mode as multiple, then incorrect mode is set for adapter. This is discussed in this issue #72.
@DevAhamed DevAhamed mentioned this issue May 3, 2019
Merged
DevAhamed added a commit that referenced this issue May 3, 2019
@DevAhamed
Fixes incorrect 'selection' and 'expansion' behaviour (#74)
945ed97 
When the sections have selection/expansion mode as single and adapter has mode as multiple, then incorrect mode is set for adapter. This is discussed in this issue #72. Same issue has been fixed in 2.x branch as well.
@DevAhamed
Copy link
Owner Author

Fixed by #73 and #74

@DevAhamed DevAhamed modified the milestones: 2.0.0-rc, 2.0.0 May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
2.x Version - Issues related to 2.x version 3.x Version - Issues related to 3.x version component-core Component - Issues related to core adapter library type:bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@DevAhamed