Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Reorganize Sidebar #686

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[Draft] Reorganize Sidebar #686

wants to merge 4 commits into from

Conversation

ajwootto
Copy link
Contributor

Re-organize extras sidebar around "topics"

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devcycle-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 1:56pm

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ajwootto - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@andrewdmaclean
Copy link
Contributor

@ajwootto is this ready for a review?

@ajwootto
Copy link
Contributor Author

@ajwootto is this ready for a review?

you can take a look and let me know what you think of how its organized but i realized it also breaks a bunch of links from our dashboard and various other places. I'm not sure if there's a good way to automatically continue redirecting from the old URLs when we do this kind of moving stuff around

@andrewdmaclean
Copy link
Contributor

Looks like the are some merge conflicts now either way...

For the redirect stuff, its just figuring out what they are and then updating this list:
https://github.com/DevCycleHQ/devcycle-docs/blob/main/vercel.json

@ajwootto
Copy link
Contributor Author

Looks like the are some merge conflicts now either way...

For the redirect stuff, its just figuring out what they are and then updating this list: https://github.com/DevCycleHQ/devcycle-docs/blob/main/vercel.json

theres so many though :(

@andrewdmaclean
Copy link
Contributor

@ajwootto this needs to have some of the merge errors resolved if we are going to move forward...

@andrewdmaclean andrewdmaclean marked this pull request as draft July 2, 2024 22:02
@andrewdmaclean andrewdmaclean changed the title Sidebar reorganize [Draft] Reorganize Sidebar Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants