Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: DVC-8020 rename DVC to DevCycle on public interfaces #169

Merged
merged 11 commits into from
Jul 21, 2023
Merged

feat!: DVC-8020 rename DVC to DevCycle on public interfaces #169

merged 11 commits into from
Jul 21, 2023

Conversation

jonathannorris
Copy link
Member

No description provided.

@jonathannorris jonathannorris requested review from jsalaber and a team July 10, 2023 20:07
suthar26
suthar26 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@suthar26 suthar26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look safe and properly deprecated the old references

@jonathannorris
Copy link
Member Author

@jsalaber let me know if you want to review this.

jsalaber
jsalaber approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@jsalaber jsalaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

DevCycleTests/Models/DevCycleClientTests.swift Outdated Show resolved Hide resolved
@jonathannorris jonathannorris merged commit 3ff0e91 into main Jul 21, 2023
7 checks passed
@jonathannorris jonathannorris deleted the DVC-8020-rename-dvc branch July 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suthar26 suthar26 suthar26 approved these changes

@jsalaber jsalaber jsalaber approved these changes

@ajwootto ajwootto Awaiting requested review from ajwootto

@nsalamad nsalamad Awaiting requested review from nsalamad

@chris-hoefgen chris-hoefgen Awaiting requested review from chris-hoefgen

Assignees
No one assigned
Labels
30 min review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathannorris @suthar26 @jsalaber