fix: batch event payloads into chunks of 100 to reduce errors on event processing #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would be good to add some tests for this |
kaushalkapasi
force-pushed
the
batch-events-payload
branch
from
1580127
to
62bd86c
Compare
kaushalkapasi
force-pushed
the
batch-events-payload
branch
4 times, most recently
from
3e883f3
to
87833aa
Compare
gitstream-cm
bot
added
20 min review
10 min review
and removed
10 min review
20 min review
labels
kaushalkapasi
force-pushed
the
batch-events-payload
branch
from
87833aa
to
ba86750
Compare
kaushalkapasi
force-pushed
the
batch-events-payload
branch
3 times, most recently
from
f3f8605
to
dfb60ed
Compare
kaushalkapasi
force-pushed
the
batch-events-payload
branch
from
dfb60ed
to
3f1dc8d
Compare
kaushalkapasi
force-pushed
the
batch-events-payload
branch
2 times, most recently
from
abfa668
to
f5ada6a
Compare
kaushalkapasi
force-pushed
the
batch-events-payload
branch
from
f5ada6a
to
3acb4ff
Compare
Comment on lines
121
to
141
| let requestBody: [String: Any] = [ | ||
| "events": batchEvents, | ||
| "user": userBody | ||
| ] | ||
|
|
||
| let jsonBody = try? JSONSerialization.data(withJSONObject: requestBody, options: .prettyPrinted) | ||
| Log.debug("Post Events Payload: \(String(data: jsonBody!, encoding: .utf8) ?? "")") | ||
| eventsRequest.httpBody = jsonBody | ||
|
|
||
| self.makeRequest(request: eventsRequest) { data, response, error in | ||
| if error != nil || data == nil { | ||
| return completion((data, response, error)) | ||
| } | ||
| // Continue with next batch | ||
| startIndex = endIndex | ||
| endIndex = min(endIndex + self.maxBatchSize, totalEventsCount) | ||
|
|
||
| if startIndex >= totalEventsCount { | ||
| return completion((data, response, nil)) | ||
| } | ||
| } |
There was a problem hiding this comment.
You could move this request code to its own method to clean this up a bit.
There was a problem hiding this comment.
updated to split the request generation into its own private function
| let data = "{\"config\":\"key}".data(using: .utf8) | ||
| let config = processConfig(data) | ||
| XCTAssertNil(config) | ||
| } | ||
|
|
||
| func testFlushingEvents() { |
There was a problem hiding this comment.
Can you make sure there is a test that if there are less than 100 events it still gets eventually flushed.
There was a problem hiding this comment.
yup, this test is only generating 20 events :) the next one batches them with 205 events
jonathannorris
approved these changes
Apr 10, 2024
jonathannorris
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macos-13-large