pre-seed all variables/features/envs before refreshing #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elliotCamblor
commented
Jul 31, 2023
elliotCamblor
commented
- This will prevent the need to fetch every single feature/env individually by caching all of the data in the state
elliotCamblor
force-pushed
the
DVC-8366-speed-up-variable-loading
branch
from
e6c5c8d
to
3c9bf87
Compare
L-Joli
reviewed
Jul 31, 2023
| @@ -44,7 +46,7 @@ export class UsagesTreeProvider | |||
|
|
|||
| private async getCombinedAPIData() { | |||
| showBusyMessage('Fetching devcycle data') | |||
| const variables = await getAllVariables() | |||
| const [variables] = await Promise.all([getAllVariables(), getAllFeatures(), getAllEnvironments()]) | |||
There was a problem hiding this comment.
I think we have initStorage() doing the same thing?
There was a problem hiding this comment.
initStorage isnt being called anywhere anymore. I think it got removed because it was being called right before storage was getting cleared
There was a problem hiding this comment.
actually Ill just remove that function altogether
elliotCamblor
force-pushed
the
DVC-8366-speed-up-variable-loading
branch
from
3c9bf87
to
036fa1f
Compare
L-Joli
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.