Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added send metrics prompt after installing #49

Merged
merged 1 commit into from
Aug 2, 2023
Merged

chore: added send metrics prompt after installing #49

merged 1 commit into from
Aug 2, 2023

Conversation

jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Aug 1, 2023

Changes

  • After user activates the extension and if they haven't seen it yet, show a popup to ask if they want to opt into sending metrics

@jsalaber jsalaber force-pushed the DVC-8397-create-send-metrics-pop-up branch 2 times, most recently from 6405216 to 2cc7d6c Compare August 1, 2023 19:52
laurawarr
laurawarr reviewed Aug 1, 2023
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
@jsalaber jsalaber force-pushed the DVC-8397-create-send-metrics-pop-up branch from 2cc7d6c to a2a4d73 Compare August 1, 2023 20:04
@jsalaber jsalaber requested a review from laurawarr August 1, 2023 20:08
@jsalaber jsalaber force-pushed the DVC-8397-create-send-metrics-pop-up branch from a2a4d73 to c918069 Compare August 2, 2023 17:26
@jsalaber jsalaber force-pushed the DVC-8397-create-send-metrics-pop-up branch from c918069 to 1917993 Compare August 2, 2023 18:00
@jsalaber jsalaber merged commit 15d2d22 into main Aug 2, 2023
1 check passed
@jsalaber jsalaber deleted the DVC-8397-create-send-metrics-pop-up branch August 2, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurawarr laurawarr laurawarr approved these changes

@elliotCamblor elliotCamblor Awaiting requested review from elliotCamblor

@emmawillis emmawillis Awaiting requested review from emmawillis

@nsalamad nsalamad Awaiting requested review from nsalamad

@L-Joli L-Joli Awaiting requested review from L-Joli

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsalaber @laurawarr