Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont fetch feature configurations on startup #61

Merged
merged 1 commit into from
Aug 3, 2023
Merged

dont fetch feature configurations on startup #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cli/cliUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

export const getCombinedVariableDetails = async (
variable: string | Variable,
skipConfigurations: boolean = false
) => {
let fullVariable: Variable
if (typeof variable === 'string') {
Expand All @@ -49,6 +50,7 @@
}

const setFeatureConfigsWithEnvNames = async () => {
if (skipConfigurations) return

Check warning on line 53 in src/cli/cliUtils.ts

View workflow job for this annotation

GitHub Actions / Test 

Expected { after 'if' condition

Check warning on line 53 in src/cli/cliUtils.ts

View workflow job for this annotation

GitHub Actions / Test 

Expected { after 'if' condition

Check warning on line 53 in src/cli/cliUtils.ts

View workflow job for this annotation

GitHub Actions / Test 

Expected { after 'if' condition

Check warning on line 53 in src/cli/cliUtils.ts

View workflow job for this annotation

GitHub Actions / Test 

Expected { after 'if' condition

Check warning on line 53 in src/cli/cliUtils.ts

View workflow job for this annotation

GitHub Actions / Test 

Expected { after 'if' condition

Check warning on line 53 in src/cli/cliUtils.ts

View workflow job for this annotation

GitHub Actions / Test 

Expected { after 'if' condition
const featureConfigurations = await getFeatureConfigurations(featureId)
await Promise.all(
featureConfigurations?.map(async (config) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/UsagesTree/UsagesTreeProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class UsagesTreeProvider
const result = {} as Record<string, VariableCodeReference>
await Promise.all(
Object.entries(variables).map(async ([key, variable]) => {
const data = await getCombinedVariableDetails(variable)
const data = await getCombinedVariableDetails(variable, true)
result[key] = data
}),
)
Expand Down
Loading