ContextMenu: fix menu height on async render (T1258881) #28553
+74
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksercs
reviewed
Dec 16, 2024
| @@ -531,6 +531,7 @@ class ContextMenu extends MenuBase { | |||
|
|
|||
| _renderSubmenuItems(node, $itemFrame: dxElementWrapper): void { | |||
| this._renderItems(this._getChildNodes(node), $itemFrame); | |||
| this._planPostRenderActions(); | |||
There was a problem hiding this comment.
I see that this function is called on render in async strategy, so now it's called twice? Doesn't it have side affects?
It's more expected for me if we call it once after everything is rendered
| @@ -1130,6 +1133,10 @@ class ContextMenu extends MenuBase { | |||
| hide(): Promise<unknown> { | |||
| return this.toggle(false); | |||
| } | |||
|
|
|||
| _postProcessRenderItems() { | |||
| this._dimensionChanged(false); | |||
There was a problem hiding this comment.
Looks not very logical that we call dimensionChanged after all items are rendered. Cannot we split the code another way? Like extract necessary code from _dimensionChanged to a new method and reuse it here
| assert.roughEqual($nestedSubmenuItemsContainer.outerHeight(), $scrollableContainer.outerHeight(), .1); | ||
| done(); | ||
| }); | ||
|
|
ksercs
reviewed
Dec 16, 2024
| const DX_SCROLLABLE_CONTENT_CLASS = 'dx-scrollable-container'; | ||
| const DX_MENU_ITEM_CLASS = 'dx-menu-item'; | ||
|
|
||
| const ITEMS_CONTAINER_PADDING = 1; |
There was a problem hiding this comment.
Now it's not used in the code
ksercs
reviewed
Dec 16, 2024
|
|
||
| const $itemsContainer = instance.itemsContainer(); | ||
| const $rootItem = $itemsContainer.find(`.${DX_MENU_ITEM_CLASS}`).eq(0); | ||
| $($itemsContainer).trigger($.Event('dxhoverstart', { target: $rootItem.get(0) })); |
There was a problem hiding this comment.
hover cannot be used on mobile devices. Feel free to do smth like
if(!isDeviceDesktop(assert)) {
assert.ok(true, 'not actual for mobile devices');
return;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.